Support multiple workload deletion from single workload delete command #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obliviour
reviewed
Feb 5, 2024
xpk.py
Outdated
| xpk_print("There are no workloads to delete matching the filter in the cluster.") | ||
|
|
||
| for workload in workloads: | ||
| result = input(f'Do you want to delete the workload: {workload} (Y/n)? ') |
There was a problem hiding this comment.
I like the yes / no user feedback logic here! two suggestions:
- Can the user enter yes/no/y/n once per workload delete command, instead of once per workload. We can print out all the workloads that are planned to be deleted. (Same as https://github.com/google/xpk/blob/main/xpk.py#L1396-L1401)
I think it would be hard to ask the user to type yes several times.
- Can you refactor the user input y/yes/n/no logic we use in node pool delete into a function and use that here as well. I think we will also need it in cluster deletion as well for a new feature request. (https://github.com/google/xpk/blob/main/xpk.py#L1396-L1401)
xpk.py
Outdated
| ) | ||
|
|
||
| ### Optional arguments | ||
| workload_delete_parser_optional_arguments.add_argument( | ||
| '--workload', | ||
| type=workload_name_type, | ||
| default=None, | ||
| help='The name of the workload to delete.', |
There was a problem hiding this comment.
Can you add that if the workload is not specified, the default behavior is that all workloads will be deleted from the cluster?
README.md
Outdated
| --cluster xpk-test | ||
| ``` | ||
|
|
||
| This will delete all the workloads in `xpk-test` cluster. Deletion will only begin if you type `Y` at the prompt for every workload. |
There was a problem hiding this comment.
nit: to adjust the readme that users only need to type yes/y once at the prompt.
| required=True, | ||
| ) | ||
|
|
||
| ### Optional arguments |
There was a problem hiding this comment.
Can you add a --force argument that skips the user prompt? This is good for automated tests for example. Or if a user really believes in themselves. You can build from https://github.com/google/xpk/blob/main/xpk.py#L2823-L2830
Obliviour
reviewed
Feb 5, 2024
Obliviour
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.