Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in ROOT master TGeo break DD4hep compilation #1210

Closed
andresailer opened this issue Jan 12, 2024 · 2 comments · Fixed by #1211 or #1212
Closed

Changes in ROOT master TGeo break DD4hep compilation #1210

andresailer opened this issue Jan 12, 2024 · 2 comments · Fixed by #1211 or #1212
Labels
bug

Comments

@andresailer
Copy link
Member

(I strongly suspect) these changes root-project/root#14327

causes these errors

https://lcgapp-services.cern.ch/cdash/upload/982612cdabd898ccd6b79a141231dcc6f0f5ede7/DD4hep-master-build.log

/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDCore/src/ShapeUtilities.cpp:437:36: error: no member named 'GetVertexIndex' in 'TGeoFacet'
        pars.emplace_back(double(f.GetVertexIndex(j)));
                                 ~ ^
1 error generated.
make[5]: *** [DDCore/CMakeFiles/DDCore.dir/build.make:1336: DDCore/CMakeFiles/DDCore.dir/src/ShapeUtilities.cpp.o] Error 1
[snip]
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDCore/src/Volumes.cpp:364:29: warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
  : TGeoExtension(c), magic(move(c.magic)), refCount(0), volIDs() {
                            ^
                            std::
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDCore/src/Volumes.cpp:366:12: warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
  volIDs = move(c.volIDs);
           ^
           std::
@MarkusFrankATcernch
Copy link
Contributor

Change is not backwards compatible. Do you know by chance the current/latest ROOT version number ?

@andresailer
Copy link
Member Author

The latest ROOT release is 6.30.02.

MarkusFrankATcernch added a commit to MarkusFrankATcernch/DD4hep that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue AIDASoft#1210
a4ec9c5
@MarkusFrankATcernch MarkusFrankATcernch mentioned this issue Jan 12, 2024
Merged
MarkusFrankATcernch added a commit to MarkusFrankATcernch/DD4hep that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue AIDASoft#1210
3715b28
MarkusFrankATcernch added a commit to MarkusFrankATcernch/DD4hep that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue AIDASoft#1210
d018d5f
MarkusFrankATcernch added a commit that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue #1210
c1b41c9
MarkusFrankATcernch added a commit that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue #1210
8771e2b
MarkusFrankATcernch added a commit that referenced this issue Jan 12, 2024
@MarkusFrankATcernch
Adapt to ROOT 6.31. See issue #1210
0a2267e
This was linked to pull requests Jan 15, 2024
Adapt to ROOT 6.31. See issue https://github.com/AIDASoft/DD4hep/issues/1210 #1211
Merged
ASSIMP: adapt for changes in TGeoTesselated in ROOT #1212
Merged
stephenswat added a commit to stephenswat/spack that referenced this issue Aug 21, 2024
@stephenswat
dd4hep: mark conflict with root@6.31.1:
6a6dc65 
dd4hep versions up to and including 1.27 had a conflict with root
versions starting from 6.31.1, as shown in
AIDASoft/DD4hep#1210. This PR explicitly adds
that conflict to the spec.
@stephenswat stephenswat mentioned this issue Aug 21, 2024
Merged
wdconinc pushed a commit to spack/spack that referenced this issue Sep 1, 2024
@stephenswat
dd4hep: mark conflict with root@6.31.1: (#45855)
3954918 
dd4hep versions up to and including 1.27 had a conflict with root
versions starting from 6.31.1, as shown in
AIDASoft/DD4hep#1210. This PR explicitly adds
that conflict to the spec.
mvlopri pushed a commit to mvlopri/spack that referenced this issue Sep 4, 2024
@stephenswat @mvlopri
dd4hep: mark conflict with root@6.31.1: (spack#45855)
e1d6bbf 
dd4hep versions up to and including 1.27 had a conflict with root
versions starting from 6.31.1, as shown in
AIDASoft/DD4hep#1210. This PR explicitly adds
that conflict to the spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@andresailer @MarkusFrankATcernch