Use edm4hep::labels::CellIDEncoding instead of "CellIDEncoding" #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
force-pushed
the
edm4hep-labels
branch
from
7231b87 to
b1e36a5
Compare
andresailer
approved these changes
Oct 17, 2024
Test Results 14 files 14 suites 5h 41m 28s ⏱️ For more details on these failures, see this check. Results for commit 0dd4383. ♻️ This comment has been updated with latest results. |
andresailer
force-pushed
the
edm4hep-labels
branch
from
f87e951 to
0dd4383
Compare
|
EIC would like to request that EDM4hep features that are not in an actual release (only in a pre-release 0.99 and 0.99.1) do not get merged into DD4hep master without backwards compatibility in place. Too many headaches are coming our way from key4hep, where it seems the criterion for merging backwards-incompatible changes seems to be that it's ok as long as someone can get the right cherry-picks to work in a key4hep stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::labels::CellIDEncodinginstead of "CellIDEncoding"podio::collMetadataParamNameinstead of hardcoding the convention of adding__ENDRELEASENOTES
See https://github.com/key4hep/EDM4hep/blob/22e85d79eca00bbd4eb479a536f90b86e76ea726/include/edm4hep/Constants.h#L29. This is the only place I could find that is related to EDM4hep.