Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: KeyError when "X" column is missing in DataFrame in windowing_df function #100

Open
gkontogiannhs opened this issue Dec 11, 2024 · 0 comments
Assignees

Comments

@gkontogiannhs
Copy link
Collaborator

gkontogiannhs commented Dec 11, 2024

The windowing_df function assumes that the input DataFrame contains a column named "X", but this assumption is not checked. If the "X" column is missing or incorrectly structured, the expression row["X"] will raise a KeyError.

Additionally, even if the "X" column exists, the function processes it row by row, treating each row["X"] as a single scalar value. This is problematic because it results in feeding a scalar value into the rolling_window_df function, which expects an iterable. This leads to unexpected behavior, particularly since windowing_df is designed to iterate through rows of the DataFrame and apply a sliding window algorithm, an approach that is unconventional for this library's typical standards (column-wise iteration treating each column as a separate dimension).

@gkontogiannhs gkontogiannhs moved this to Todo in CrossAI-TS Dec 11, 2024
@gkontogiannhs gkontogiannhs self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant