Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate overlapping nodes better #212

Open
AJamesPhillips opened this issue Jan 25, 2022 · 0 comments
Open

Calculate overlapping nodes better #212

AJamesPhillips opened this issue Jan 25, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AJamesPhillips
Copy link
Owner

Describe the bug

Two nodes which are not overlapping show the overlapping icon
Two nodes which are overlapping do not show the overlapping icon

To Reproduce

Steps to reproduce the behavior:

  1. Create a node (double click on the canvas so it is positioned on the main horizontal and vertical increments)
  2. Create a second node to the right of it and move it left by 4 increments
  3. Select both and move them over by 6 small increments
  4. Observe the overlapping icon is present on both nodes despite them not overlapping

image

  1. Only moving them both left by only 4 does correctly not show the over lapping icon.

image

  1. Create the second node and move it left by 9 small increments to overlap the other.
  2. Observe it does not display the overlapping icon

image

  1. (Move them both left by 1 and observe the overlapping icon appears)

image

Expected behavior

Should only show the overlapping icon when they overlap.

Additional context

Would be great to factor in the node size as well (if this is not done already).

@AJamesPhillips AJamesPhillips added bug Something isn't working good first issue Good for newcomers labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant