Extended PEtab test suite / cleanup PEtab state reinitialization #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1344 +/- ##
===========================================
+ Coverage 78.80% 88.04% +9.24%
===========================================
Files 63 2 -61
Lines 9944 1405 -8539
===========================================
- Hits 7836 1237 -6599
+ Misses 2108 168 -1940
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
This was referenced Feb 1, 2021
Closed
dweindl
changed the title
|
Closing, as this isn't going to work as intended... |
dweindl
added a commit
that referenced
this pull request
Feb 18, 2021
…fixes (#1417) Adds possibility to provide state indices for selective reinitialization based on fixed parameters. The previous `ExpData::reinitializeFixedParameterInitialStates` is still there, but will be removed in an upcoming version. Addresses #1345, #1396, #1319 Supersedes #1344 Include new test cases from PEtab-dev/petab_test_suite#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include cases from PEtab-dev/petab_test_suite#35
Related to #1319