an EOS interface with NSE #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works by differentiating the cubic interpolant
|
this seems to work really well now, but needs a bit of cleaning |
|
this is ready, but depends on #1407 so that should be reviewed / merged first |
zhichen3
reviewed
Dec 20, 2023
|
|
||
| constexpr bool skip_X_fill{true}; | ||
| nse_interp(nse_state, skip_X_fill); | ||
| Real abar_old = nse_state.abar; |
There was a problem hiding this comment.
This abar_old looks unncessary?
There was a problem hiding this comment.
I think it's needed for the EOS call
There was a problem hiding this comment.
I mean why can't we just do nse_state.abar in line 71
There was a problem hiding this comment.
oh. we could. I didn't think it mattered much.
zhichen3
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solving for T(e) or T(p) in NSE is trickier than our standard interface because Abar and Zbar are
also a function of rho, T, Ye through the NSE table. This does a self-consistent inversion of the
EOS together with the NSE table.