-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional quantum correction terms for chabrier1998 #1428
optional quantum correction terms for chabrier1998 #1428
Conversation
do we expect such large diffs from this PR? |
oh there is a bug in the script I wrote that it wouldn't pick up the correct integer power if there are multiple commas (such as pow inside a pow). That was the case for gcem::pow in chugunov2009, and you ran the test suite before I added that so it didn't pick it up. |
Is it possible to run it with |
yep, I'll do that in the suite |
added a runtime parameter to make quantum correction terms in chabrier1998 screening optional. This is because in NSE_solver quantum terms are not included.
Also fixed some inconsistent indentations
This should also speed up this screening a little bit (issue #1396), although we already switched integer pows to powi.
pr #1426 should be reviewed before this.