Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional quantum correction terms for chabrier1998 #1428

Merged

Conversation

zhichen3
Copy link
Collaborator

added a runtime parameter to make quantum correction terms in chabrier1998 screening optional. This is because in NSE_solver quantum terms are not included.

Also fixed some inconsistent indentations

This should also speed up this screening a little bit (issue #1396), although we already switched integer pows to powi.

pr #1426 should be reviewed before this.

@zingale
Copy link
Member

zingale commented Dec 31, 2023

@zingale
Copy link
Member

zingale commented Dec 31, 2023

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Jan 1, 2024

chug09 fails to compile: http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2023-12-31-003/test_screening_chug09.html

oh there is a bug in the script I wrote that it wouldn't pick up the correct integer power if there are multiple commas (such as pow inside a pow). That was the case for gcem::pow in chugunov2009, and you ran the test suite before I added that so it didn't pick it up.

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Jan 1, 2024

do we expect such large diffs from this PR? http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2023-12-31-003/test_screening_chabrier1998.html

Is it possible to run it with screening.enable_chabrier1998_quantum_corr=1? Results should be identical if things are correct.

@zingale
Copy link
Member

zingale commented Jan 1, 2024

yep, I'll do that in the suite

@zingale
Copy link
Member

zingale commented Jan 1, 2024

@zingale zingale merged commit 3185974 into AMReX-Astro:development Jan 1, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants