Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start moving away from "using namespace amrex" #1465

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 4, 2024

No description provided.

@zingale
Copy link
Member Author

zingale commented Feb 5, 2024

waiting on: pynucastro/pynucastro#718

@zingale
Copy link
Member Author

zingale commented Feb 6, 2024

#1470 needs to be merged first

@zingale zingale marked this pull request as draft February 7, 2024 21:35
@zingale zingale marked this pull request as ready for review February 8, 2024 19:17
Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zingale zingale merged commit b5d1a91 into AMReX-Astro:development Feb 8, 2024
27 checks passed
@zingale zingale deleted the cleanup_headers branch February 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants