-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official EventBuilding ToolChain #253
Conversation
EventBuilder ToolChain - very similar to DataDecoder toolchain, with some minor configuration differences: - Updated trigger mask to include all triggers (1-64) - Updated LoadGeometry file path for Gian's new gain calibration data - Added Johann's SaveConfigInfo tool - Excluded Stage1DataBuilder until bug fix - Minor fix in ANNIEEventBuilderConfig (changing true/false to 1/0) - Updated file paths for more recent data
Part of updated the BeamFetcher toolchain (needed prior to event building)
Included a copy of the run info from the SQL webpage in the local toolanalysis directory
added local SQL run information for fetching beam info
updated path for trigger mask to include all triggers
added new paths for event building
Updated gains file path within the LoadGeometryConfig file in the LoadGeometry toolchain - many tools call this config file (configfiles/LoadGeometry), instead of calling their own LoadGeometryConfig file that is present within that specific toolchain. Instead of replacing every path within all config files, replace this one.
After testing the new EventBuilder toolchain, including all triggers in the triggermask file seems to slow the toolchain down by 2x (or so). Going back to default file.
Added necessary trigwords for AmBe external trigger (15) and laser (46 or 47, dependent on settings. Through the current laser run campaign, various configurations will either lead to the trigword being 46 or 47... not sure why).
For now, omit BeamDecoder until we have BeamFetcherv2 up and running
Include the undelayed beam trigger for retroactive LAPPD time matching with other subsystems. If there is an LAPPD event, this triggerword can be used to check if the LAPPD event is correctly aligned, in case any hardware was broken (according to Yue)
I swear this is the final change. Yue initially requested I put this trigword in, however he recently encountered errors when trying to pair the LAPPDs to the MRD. For now, omitting this trigword until he can find a suitable trigword for LAPPD timing alignment
Sweet! These all sound like great changes. And CI seems to have run successfully for this one, which is also good news. 🎉 I see here the dreaded words DaylightSavings and DaylightSavingsSpring .... I thought in one of your previous PRs we removed dependence on DST timestamps? What is this related to? Is there a non-DST alternative? very minor point, but technically comments should be marked with Another minor comment is that it's generally best not to commit high verbosity levels, as excessive printouts can slow down processing considerably. As for the outstanding issues, I won't let them hold this up, but we have an update on those? |
Lowering the verbosity
Thanks for the comments - I will talk to Yue and Rory about the LAPPD related action items (for Yue, adding tools to do the time matching, for Rory fixing the segfault). As for DST, I can add a separate PR modifying the Only question I have is that I was under the impression that the MRD records timestamps in CDT or some other daylight savings dependent time zone, so if we are trying to pair events with the CTC or Tank, how do we modify this correctly? For the old beamfetcher changes to fix DST dependencies, the SQL times used to be in local chicago time, and the tool then adjusted that time into UTC. SQL was then changed to UTC, and the shift was removed from the tool. If the MRD records timestamps in local Chicago time, it appears there is no reference for the MRD tool to use to convert to UTC, correct? Unless I'm missing something simple |
Since we are omitting the beamfetcher tool for now, do not store the beam information in the final annieevent
change config file comments to use `#` instead of `//`
see commit info, but here is a brief description of the changes (mostly changes to DataDecoder and other toolchains' config files)
To do: