Improve LAPPD Data Monitoring #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were previously summing all of the points recorded in PPS accumulated number vector, resulting in an exponential graph, which is incorrect. We now sum only the previous number - which creates a meaningful graph.
- ROOT handles it anyway if the numbers get too big, so we don't need to do it
- turns out i didn't need to store some of the properties in vectors, as entries kind of do the same
furkan-bilgin
force-pushed
the
Application
branch
from
ce9428c to
0d6800b
Compare
- `MonitorLAPPDData` also reads `LAPPD_ID` from `LAPPDTemp` now
furkan-bilgin
force-pushed
the
Application
branch
from
aa7ede9 to
9c13449
Compare
|
Hi Furkan, sorry for the delay on this. The online monitoring toolchain was on my fork because I was getting 403 errors trying to push it to the main anniesoft one (it used to be on michael's fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.