Bugfix for LoadRawData tool #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to allow event builder to construct MRD + CTC entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of MRD entries exceeds the number of tank entries when loading in the raw data, the tool (and resulting toolchain) stops. Not sure why the condition exists, but when we are trying to build events without the Tank (MRD efficiency analysis for example) we don't expect any Tank entries so this condition shouldn't apply.
There is an exception for building MRD-only events (BuildType = MRD) however this should be expanded to also include BuildType = MRDAndCTC if we are interested in the MRD + CTC event pairing.