EventBuilder toolchain to include Beam information #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeamFetcherV2 and BeamQuality tools replace BeamDecoder functionality
BeamFetcherV2 device list (currently set to read all of them)
drop verbose
|
i notice we still have in the MRDDataDecoder. I guess unrelated to this PR, but is that still relevant? Can we calculate whether daylight savings time is relevant based on the event time and add it automatically? |
|
Yeah its still relevant and should be changed. I'll add an MRD timestamp check on previous daylight savings periods to automatically assign it 1 or 0. Will open a new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in new beam tools (
BeamQuality+BeamFetcherV2) to extract, save, and pass beam info into the final ANNIEEvent. These tools replaceBeamDecoder.