ADC hit time fix #314
Merged
ADC hit time fix #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned correct 50% interpolation time instead of max ADC time
clean up verbose of the hit finding tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the laser timing analysis, we changed how the PMT hit times are assigned. Instead of taking the ADC value where the pulse maximum is found, we interpolate the rising edge of the pulse and find 50% above baseline. This PR fixes a bug from a previous commit so that this new hit time is now saved correctly in the pulses vector.
Also fixed up some verbose in the hit finding tool.