Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv file output to PrintDQ #328

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

S81D
Copy link
Contributor

@S81D S81D commented Dec 18, 2024

Describe your changes

In an effort to streamline the workflow for analyzing metrics across multiple runs, the tool now outputs the statistics to a .csv file. These can be stored somewhere on the gpvms so others can access the run data and create DQ plots.

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • [N/A] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • [N/A] If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • For every new usage, there is a reason the data must be on the heap
  • For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

See README for the tool.

@S81D
Copy link
Contributor Author

S81D commented Dec 18, 2024

As for the "new" usage and subsequent deletion checklist points, instead of this:

std::ofstream* csv_file = new std::ofstream(filename);
delete csv_file; 

I just use this:

std::ofstream csv_file(filename);

I think this handles the memory fine but please let me know if I need to change anything.

@marc1uk marc1uk merged commit 4a88c36 into ANNIEsoft:Application Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants