Bugfix for unsmeared hit times in LoadWCSim #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: photon hits from WCSim use unsmeared or smeared hit times (set in config file). It was noticed the unsmeared hit times were systematically shifted towards larger times for delayed hits (> 2us). Smeared hit times did not seem to have this problem.
In the code, the event time was added back to the hit times. It was determined that the unsmeared hits are with respect to the global MC time, so they do not require this addition. Smeared hit times are taken from WCSim digits, and are triggered output so require this addition to ensure all timing is consistent.
Upon testing the issue is remedied with the proposed changes.
Describe your changes
Checklist before submitting your PR
new
usage, there is a reason the data must be on the heapnew
there is adelete
, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
More details on the bug fix and further explanations can be found here.