Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for unsmeared hit times in LoadWCSim #331

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

S81D
Copy link
Contributor

@S81D S81D commented Jan 9, 2025

Bug fix: photon hits from WCSim use unsmeared or smeared hit times (set in config file). It was noticed the unsmeared hit times were systematically shifted towards larger times for delayed hits (> 2us). Smeared hit times did not seem to have this problem.

In the code, the event time was added back to the hit times. It was determined that the unsmeared hits are with respect to the global MC time, so they do not require this addition. Smeared hit times are taken from WCSim digits, and are triggered output so require this addition to ensure all timing is consistent.

Upon testing the issue is remedied with the proposed changes.

Describe your changes

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • [N/A] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • [N/A] If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • [N/A] For every new usage, there is a reason the data must be on the heap
  • [N/A] For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

More details on the bug fix and further explanations can be found here.

Unsmeared hits are relative to MC global time. Adding in the event time was causing an artificial shift in the hit times if smeared hit times was turned off.
@marc1uk marc1uk merged commit 5b3a549 into ANNIEsoft:Application Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants