-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error report on Marketplace #104
Comments
@AObuchow It could not hurt to give it a min version. Although, not specifying any version typically allows any version. But, maybe the Eclipse version the user has doesn't have access to any version of |
@mbooth101 any ideas? :) |
I'll try setting a min version and see if it helps. I wonder why someone wouldn't have |
Yes, me too. But your plug-in doesn't require any min version, so in theory it should be possible to launch the installer on something like Eclipse Juno, as well (Eclipse 3.8). Or does the Marketplace entry as such restrict access to your plug-in to 2020-06 in a technical way? (I have no experience w/ setting up Marketplace entries). |
I don't know. It's pretty annoying it doesn't give you details about which version of Eclipse they are using. |
@mbooth101 right! Maybe I'll file a bug regarding adding more info to the error details. |
In the meantime, I would just make it obvious from the marketplace listing that this github project is the best place to report problems. This anonymous market place error is pretty inactionable IMO, but if users actually come here to report problems themselves, then we can chat to them to extract all the detail necessary to help them fix their problem. |
@mbooth101 +1 that's a good idea, I went ahead and modified the marketplace listing: I could have maybe worded it better - anyone is free to suggest how it should be written :P |
Part of #104 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Part of #104 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Unfortunately, I don't think adding a minimum version requirement to org.eclipse.e4.ui.css.swt.theme made much of a difference:
I could try lowering the version requirement, as this might have made only Eclipse 2020-06/4.16 users able to use it... However, ideally they should just upgrade to Eclipse 4.16 🤔 |
You'd be surprised how many people come into the IRC channel under the misapprehension that they are using the latest Eclipse, but it turns out to be Oxygen (4.7) or similar vintage... :-o |
@mbooth101 oh my hahah 😅 Well, if people want the plugin to be compatible with an earlier version of Eclipse they can make a bug I suppose. IIRC I tried my theme on Eclipse 4.13 and it had some issues with the tabs. The theme is actually using swt-active-tab-highlight which only came out in 4.16. |
Part of AObuchow#104 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
For your information, I'm getting very similar errors with my Planet Themes, though it's for bundle |
@PyvesB thanks for info, good to know :) |
There's some error reports I've been seeing on marketplace:
It might be related to not specifying a version for org.eclipse.e4.ui.css.swt.theme? See: https://github.com/AObuchow/Eclipse-Spectrum-Theme/blob/master/com.aobuchow.themes.spectrum/META-INF/MANIFEST.MF#L9
The text was updated successfully, but these errors were encountered: