Projects that have Git changes have different font color

[PyvesB]

Hello, hello!

In the Package Explorer on my macOS machine, I noticed that Git projects that have changes appear with a slightly darker font colour. See below:

Is this intentional? If it is, I would have expected the two colours to be inverted, in other words the projects with changes to have the lighter colour, so that they stick out more and indicate to the user that there are uncommitted changes. That's only my personal opinion though, I'm not too fussed as this is only a minor detail. 😉

Let me know if you need any more information!

[AObuchow]

Agreed the colour indications for uncommitted changes should be more obvious.

One issue is that the git colours get set with preferences, so unfortunately they aren’t able to inherit the colours used in the theme very easily. An upstream change to egit might be needed to simplify things.

For the time being, I can hardcode new colour preferences for egit to improve this.

[AObuchow]

Upstream bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=564970

Edit: this is actually related to the project explorer font being overridden by the egit uncommitted change font. Sorry about that.

[AObuchow]

@PyvesB I'm excited to let you know that the latest experimental patch I'm working on adds some "dynamic" theming. Now, preferences such as egit's uncommitted changes foreground/background will be set to use Spectrum Theme's background/base/accent colors :D