Removing Laravel 5.4 Support from v1.2 branch

+ Some cleaning

.scrutinizer.yml

@@ -21,8 +21,8 @@ checks:
 
 tools:
     external_code_coverage:
-        timeout: 1200
-        runs: 12
+        timeout: 900
+        runs: 9
     php_code_sniffer:
         enabled: true
         config:

.travis.yml

@@ -16,7 +16,6 @@ env:
   - TESTBENCH_VERSION=3.1.*
   - TESTBENCH_VERSION=3.2.*
   - TESTBENCH_VERSION=3.3.*
-  - TESTBENCH_VERSION=3.4.*
 
 before_script:
   - travis_retry composer self-update

src/Facades/SeoHelper.php

@@ -1,5 +1,6 @@
 <?php namespace Arcanedev\SeoHelper\Facades;
 
+use Arcanedev\SeoHelper\Contracts\SeoHelper as SeoHelperContract;
 use Illuminate\Support\Facades\Facade;
 
 /**
@@ -15,5 +16,5 @@ class SeoHelper extends Facade
      *
      * @return string
      */
-    protected static function getFacadeAccessor() { return 'arcanedev.seo-helper'; }
+    protected static function getFacadeAccessor() { return SeoHelperContract::class; }
 }

src/Facades/SeoMeta.php

@@ -1,5 +1,6 @@
 <?php namespace Arcanedev\SeoHelper\Facades;
 
+use Arcanedev\SeoHelper\Contracts\SeoMeta as SeoMetaContract;
 use Illuminate\Support\Facades\Facade;
 
 /**
@@ -15,5 +16,5 @@ class SeoMeta extends Facade
      *
      * @return string
      */
-    protected static function getFacadeAccessor() { return 'arcanedev.seo-helper.meta'; }
+    protected static function getFacadeAccessor() { return SeoMetaContract::class; }
 }

src/Facades/SeoOpenGraph.php

@@ -1,5 +1,6 @@
 <?php namespace Arcanedev\SeoHelper\Facades;
 
+use Arcanedev\SeoHelper\Contracts\SeoOpenGraph as SeoOpenGraphContract;
 use Illuminate\Support\Facades\Facade;
 
 /**
@@ -15,5 +16,5 @@ class SeoOpenGraph extends Facade
      *
      * @return string
      */
-    protected static function getFacadeAccessor() { return 'arcanedev.seo-helper.open-graph'; }
+    protected static function getFacadeAccessor() { return SeoOpenGraphContract::class; }
 }

src/Facades/SeoTwitter.php

@@ -1,5 +1,6 @@
 <?php namespace Arcanedev\SeoHelper\Facades;
 
+use Arcanedev\SeoHelper\Contracts\SeoTwitter as SeoTwitterContract;
 use Illuminate\Support\Facades\Facade;
 
 /**
@@ -15,5 +16,5 @@ class SeoTwitter extends Facade
      *
      * @return string
      */
-    protected static function getFacadeAccessor() { return 'arcanedev.seo-helper.twitter'; }
+    protected static function getFacadeAccessor() { return SeoTwitterContract::class; }
 }

src/Providers/UtilityServiceProvider.php

@@ -49,9 +49,6 @@ public function register()
     public function provides()
     {
         return [
-            'arcanedev.seo-helper.meta',
-            'arcanedev.seo-helper.open-graph',
-            'arcanedev.seo-helper.twitter',
             Contracts\SeoMeta::class,
             Contracts\SeoOpenGraph::class,
             Contracts\SeoTwitter::class,
@@ -73,8 +70,6 @@ private function registerSeoMetaService()
 
             return new SeoMeta($config->get('seo-helper'));
         });
-
-        $this->singleton('arcanedev.seo-helper.meta', Contracts\SeoMeta::class);
     }
 
     /**
@@ -88,8 +83,6 @@ private function registerSeoOpenGraphService()
 
             return new SeoOpenGraph($config->get('seo-helper'));
         });
-
-        $this->singleton('arcanedev.seo-helper.open-graph', Contracts\SeoOpenGraph::class);
     }
 
     /**
@@ -103,7 +96,5 @@ private function registerSeoTwitterService()
 
             return new SeoTwitter($config->get('seo-helper'));
         });
-
-        $this->singleton('arcanedev.seo-helper.twitter', Contracts\SeoTwitter::class);
     }
 }

src/SeoHelperServiceProvider.php

@@ -52,7 +52,9 @@ public function getBasePath()
     public function register()
     {
         $this->registerConfig();
+
         $this->registerProvider(Providers\UtilityServiceProvider::class);
+
         $this->registerSeoHelperService();
     }
 
@@ -74,7 +76,6 @@ public function boot()
     public function provides()
     {
         return [
-            'arcanedev.seo-helper',
             Contracts\SeoHelper::class,
         ];
     }
@@ -89,6 +90,5 @@ public function provides()
     private function registerSeoHelperService()
     {
         $this->singleton(Contracts\SeoHelper::class, SeoHelper::class);
-        $this->singleton('arcanedev.seo-helper', Contracts\SeoHelper::class);
     }
 }

tests/Providers/UtilityServiceProviderTest.php

@@ -58,9 +58,6 @@ public function it_can_be_instantiated()
     public function it_can_provides()
     {
         $expected = [
-            'arcanedev.seo-helper.meta',
-            'arcanedev.seo-helper.open-graph',
-            'arcanedev.seo-helper.twitter',
             \Arcanedev\SeoHelper\Contracts\SeoMeta::class,
             \Arcanedev\SeoHelper\Contracts\SeoOpenGraph::class,
             \Arcanedev\SeoHelper\Contracts\SeoTwitter::class,

tests/SeoHelperServiceProviderTest.php

@@ -58,7 +58,6 @@ public function it_can_get_service_provider()
     public function it_can_provides()
     {
         $expected = [
-            'arcanedev.seo-helper',
             \Arcanedev\SeoHelper\Contracts\SeoHelper::class,
         ];
 

tests/SeoMetaTest.php

@@ -61,7 +61,7 @@ public function it_can_be_instantiated()
     /** @test */
     public function it_can_be_instantiated_by_container()
     {
-        $this->seoMeta = $this->app['arcanedev.seo-helper.meta'];
+        $this->seoMeta = $this->app[\Arcanedev\SeoHelper\Contracts\SeoMeta::class];
 
         $this->assertInstanceOf(SeoMeta::class, $this->seoMeta);
         $this->assertNotEmpty($this->seoMeta->render());