Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in CpuIm2ColKernel.cpp #1140

Open
VladislavZavadskyy opened this issue Sep 23, 2024 · 1 comment
Open

Possible bug in CpuIm2ColKernel.cpp #1140

VladislavZavadskyy opened this issue Sep 23, 2024 · 1 comment
Labels
Milestone

Comments

@VladislavZavadskyy
Copy link

Hello, I'm trying to make sense of the code, and stumbled onto this piece of code:

_convolved_dims  = scaled_dimensions(src->dimension(width_idx), dst->dimension(height_idx), _kernel_width,
                                     _kernel_height, _conv_info, _dilation);

Shouldn't it be src->dimension(height_idx)?

Sorry in advance if this is intended, as I've said I'm only trying to make sense of it all, to add a custom kernel. I would be grateful if you could explain why dst is there, if it's not a bug. Thanks!

@morgolock
Copy link

Hi @VladislavZavadskyy

Thanks for raising this. This patch solves the problem.

Hope this helps

@morgolock morgolock added this to the v24.11 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants