Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State management #109

Merged
merged 21 commits into from
Aug 6, 2023
Merged

State management #109

merged 21 commits into from
Aug 6, 2023

Conversation

mufniarz
Copy link
Contributor

@mufniarz mufniarz commented Aug 4, 2023 •
edited
Loading

Description

Replaced AuthService w/ AuthStoreService.
Added a StoreService to manage Users and Groups in memory.
Updated all pages that referenced GroupsService and UsersService with StoreService.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Regression Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mufniarz mufniarz added Enhancement New feature, request or enhancement. Priority: Low For low-priority tasks. Refactor For code refactoring or optimization tasks. Status: Code Review For tasks that require a code review or additional feedback. Effort: Hard For tasks that require significant effort or expertise. role - frontend developer Role: Developer Work that can be taken on by a developer. labels Aug 4, 2023
@mufniarz mufniarz added this to the Minimum Viable Product(MVP) milestone Aug 4, 2023
@mufniarz mufniarz self-assigned this Aug 4, 2023
@mufniarz mufniarz merged commit 975c036 into ASCENDynamics-NFP:main Aug 6, 2023
2 checks passed
@mufniarz mufniarz deleted the state-management branch August 6, 2023 15:19
@mufniarz mufniarz linked an issue Aug 6, 2023 that may be closed by this pull request
Implement State Management in Angular using Firebase for users, groups, and relationships collections #105
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mufniarz mufniarz

Labels
Effort: Hard For tasks that require significant effort or expertise. Enhancement New feature, request or enhancement. Priority: Low For low-priority tasks. Refactor For code refactoring or optimization tasks. Role: Developer Work that can be taken on by a developer. Status: Code Review For tasks that require a code review or additional feedback.
Projects
Cooperative Platform
Archived in project
Milestone
Minimum Viable Product(MVP)
Development

Successfully merging this pull request may close these issues.

Implement State Management in Angular using Firebase for users, groups, and relationships collections
1 participant
@mufniarz