-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-class movie creation mode #542
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 62.87% 62.24% -0.63%
==========================================
Files 33 33
Lines 4611 4656 +45
==========================================
- Hits 2899 2898 -1
- Misses 1712 1758 +46
Continue to review full report at Codecov.
|
|
Currently I would much prefer looking into a solution that just uses a Qt interface (or we hand-craft a direct-to-png writer) and directly saves the canvas to png. Converting ps to png takes maybe 10 seconds per frame which is far too much time. |
Additional open idea: Do we actually need mp4 video files? Maybe an animated Javascript canvas is the better solution for presenting the matches after the tournament anyway. Obviously low priority. |
8e17c7f
to
2299359
Compare
2299359
to
5581c1c
Compare
Codecov Report
@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 85.39% 85.32% -0.08%
==========================================
Files 21 21
Lines 2301 2303 +2
==========================================
Hits 1965 1965
- Misses 336 338 +2
Continue to review full report at Codecov.
|
Please do not yet merge. The new code as well as the surrounding old Tk code needs some more polishing.
This adds the highly sought-after (#531, #524 (comment)) ‘automatic replay movie creation mode’ to Pelita, which uses Tk’s
Canvas.postscript
function to write a postscript representation. As the generated postscript depends on what is shown on the screen, this mode also activates a few changes in the UI representation.Usage:
For personal convenience, I am creating a
ninja.build
automatically. Not strictly needed since we are only expected to convert it once (except for testing, where it is useful) and a bash script should do just fine. But parallelisation is nice. :)Current drawbacks: