-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure BSK_RL is compatible with BSK installation #89
Comments
Ah, good catch. I believe that's a result of #90, which adds a flag to the info sometimes that's not in the form A documentation system is currently being put together and that'll change how example scripts are formatted and handled. Currently, example scripts aren't being caught in the test suite; I'll make sure that they are tested when we make that change so that PRs that break common use patterns like this are avoided in the future. |
@LorenzzoQM, could you review #92 which refactors the previous PR? |
@jbbennett91 Should be resolved now with #92 . As an additional heads up, there's a PR that'll be switching us to a src-style package coming up, so you may need to uninstall and reinstall the package. |
Over in Basilisk, @patkenneally is looking into automated beta version number increasing (so that each commit increases bsk version to 2.2.1b1, 2.2.1b2, 2.2.1b3, etc). This will allow us to match our develop to specific bsk versions without needing to dig around for commit hashes. Considering code like this in the
|
Relevant to #14, since our released versions should probably match certain bsk releases
I think we should check on import that a minimum version of bsk_rl is installed (by version? by commit hash for develop?) and warn the user if it is not
The text was updated successfully, but these errors were encountered: