Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #86: Update BSK gravFactory #100

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented Dec 14, 2023

Description

Closes #86

Updates to use new bsk grav factory api

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

  • Python: [e.g. 3.10.1]
  • Basilisk: [e.g. 2.2.0]
  • Platform: [e.g. Ubuntu 22.08]

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Mark2000 Mark2000 force-pushed the feature/86-grav-factory-update branch from 5634386 to 9899c7c Compare December 14, 2023 22:34
@Mark2000 Mark2000 requested a review from LorenzzoQM December 14, 2023 22:34
Copy link
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mark2000 Mark2000 merged commit 781e00e into develop Dec 15, 2023
4 checks passed
@Mark2000 Mark2000 deleted the feature/86-grav-factory-update branch December 15, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new BSK gravity factory
2 participants