Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #51: Add --no-deps for chebpy in Mac ARM #110

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

LorenzzoQM
Copy link
Contributor

Description

Closes #51

This pull request fixes the errors when installing pyfftw as part of the requirements for chebpy in Mac OS with ARM architecture.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Passes Tests

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
  • Examples (General Environment only) pytest tests/examples

Test Configuration

  • Python: 3.11.6
  • Basilisk: 2.2.1b0
  • Platform: Mac OS 14.2.1

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM self-assigned this Jan 17, 2024
@LorenzzoQM LorenzzoQM requested review from Yume27 and Mark2000 January 17, 2024 23:37
@Mark2000
Copy link
Contributor

@Yume27 could you review this PR that fixes the issue you were running into? Generally when we review pull requests, we read the code and make sure it makes sense and (if relevant, so not here) has tests that make sense. In some cases where things are unclear, it may be good to pull and test code yourself or ask the person who made the PR for proof that it works if you aren’t sufficiently convinced.

@LorenzzoQM LorenzzoQM merged commit f5b0e76 into develop Jan 18, 2024
4 checks passed
@LorenzzoQM LorenzzoQM deleted the bugfix/51-error-install-chebpy branch January 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting up bsk_rl environment using setup.py
3 participants