Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #116: Add observation of angle between instrument and target #117

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

LorenzzoQM
Copy link
Contributor

Description

Closes #116

Now it is possible to add the angle between the sensing instrument and the target in the observations using the target_angle option.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Passes Tests

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
  • Examples (General Environment only) pytest tests/examples

Test Configuration

  • Python: 3.11.6
  • Basilisk: 2.2.2
  • Platform: MacOS Sonoma 14.2.1

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM self-assigned this Feb 16, 2024
@LorenzzoQM LorenzzoQM force-pushed the feature/116_add_target_angle_observation branch from 23e9c2e to 669943b Compare February 16, 2024 21:41
@LorenzzoQM LorenzzoQM requested a review from Mark2000 February 16, 2024 21:42
@Mark2000
Copy link
Contributor

Could you add a unit test or two for this functionality? Otherwise looks good

@LorenzzoQM LorenzzoQM force-pushed the feature/116_add_target_angle_observation branch from d607530 to 78d1eca Compare February 16, 2024 23:48
@LorenzzoQM LorenzzoQM requested review from Mark2000 and removed request for Mark2000 February 16, 2024 23:50
Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LorenzzoQM LorenzzoQM merged commit b37475f into develop Feb 17, 2024
4 checks passed
@LorenzzoQM LorenzzoQM deleted the feature/116_add_target_angle_observation branch February 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add observation of angle between instrument and target
2 participants