Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #130: Infer environment model type #131

Merged
merged 1 commit into from
May 2, 2024

Conversation

Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented May 1, 2024

Description

Closes #130

Makes env_type an optional argument

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Passed unit tests, added new ones.

Passes Tests

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
  • Examples (General Environment only) pytest tests/examples

Test Configuration

  • Python: 3.10
  • Basilisk: 2.3.0
  • Platform: MacOS

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Mark2000 Mark2000 requested a review from LorenzzoQM May 1, 2024 23:41
@Mark2000 Mark2000 force-pushed the feature/130-env-model-type branch 4 times, most recently from 68fbad7 to 62203be Compare May 1, 2024 23:55
Copy link
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the repo!

@Mark2000 Mark2000 force-pushed the feature/130-env-model-type branch from 62203be to 6297a9e Compare May 2, 2024 19:28
@Mark2000 Mark2000 merged commit f4ae2c1 into develop May 2, 2024
4 checks passed
@Mark2000 Mark2000 deleted the feature/130-env-model-type branch May 2, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer environment model type from satellites
2 participants