Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #203: Warning if initial battery or buffer initial levels are inadequate #204

Merged

Conversation

LorenzzoQM
Copy link
Contributor

Description

Closes #203

Passing an initial battery charge or buffer level incompatible with the maximum capacity leads to initialization with a full battery or zero buffer level. Now, it creates a warning indicating that this is occurring.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Unit tests were created to check if the warning was being correctly generated.

Future Work

None.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good check.

@LorenzzoQM LorenzzoQM merged commit 20ff77e into develop Oct 4, 2024
5 checks passed
@LorenzzoQM LorenzzoQM deleted the feature/203-warning-battery-buffer-initial-level branch October 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when battery and buffer initial levels are incompatible with their capacities
2 participants