Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #0: Clean up extraneous logging #209

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

Mark2000
Copy link
Contributor

Description

Removes logging of truncated = False, terminated = False, and reward = 0.0

Greatly improves readability in multiagent cases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

CI

Future Work

What future tasks are needed, if any?

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

@Mark2000 Mark2000 force-pushed the feature/logging-clean branch from f2117a0 to c4ab0ca Compare October 10, 2024 21:42
@Mark2000 Mark2000 merged commit 45b941e into develop Oct 10, 2024
5 checks passed
@Mark2000 Mark2000 deleted the feature/logging-clean branch October 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants