Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #18: Maintain current action by selecting None action #90

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented Dec 1, 2023

Description

Closes #18

Allows actions to add RETASKING_REQUIRED to info on action completion. If it is present, the user should assign a new task (currently only a print statement alerts this, didn't want to use warn so it isn't surpressed; maybe we should add a logger eventually?). If the symbol is not present, the user may task None to continue the current task.

This is generally useful in variable-interval, multiagent systems; if one satellite finishes a task, the step will end; it may be desirable to have other satellites continue their current action rather than retask.

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tests still pass, new tests added.

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

  • Python: 3.10.11
  • Basilisk: 2.2.1b
  • Platform: MacOS 13.3.1

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Mark2000 Mark2000 force-pushed the feature/18-dont-retask branch from 368bb31 to 2bdde1e Compare December 1, 2023 18:21
@Mark2000 Mark2000 requested a review from LorenzzoQM December 1, 2023 18:22
Copy link
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mark2000 Mark2000 merged commit 37adacb into develop Dec 1, 2023
8 checks passed
@Mark2000 Mark2000 deleted the feature/18-dont-retask branch December 1, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retasking setting for general environment
2 participants