Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #17: Sphinx documentation #98

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

johnowagon
Copy link
Contributor

@johnowagon johnowagon commented Dec 11, 2023

Description

Part of #17

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Does not change code functionality

Test Configuration

  • Python: [3.10.1]
  • Basilisk: [2.2.0]
  • Platform: [OSX 12.6.6]

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

To test locally since auto-generated documentation files are not being tracked by git:
From project root:

sphinx-apidoc -e -f -o docs/source/documentation src/bsk_rl/
cd docs && make html

The output pages can be viewed from docs/build/html/index.html. Note that some pieces of documentation may look wrong, this is due to some syntax errors in docstrings, #94 addresses and fixes these issues.

@johnowagon johnowagon requested a review from Mark2000 December 11, 2023 15:37
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch from 2b7e2c0 to abdb9da Compare December 28, 2023 18:02
@Mark2000 Mark2000 removed their request for review December 28, 2023 18:02
@Mark2000 Mark2000 mentioned this pull request Dec 28, 2023
15 tasks
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch from d31aec4 to d03da7a Compare December 29, 2023 01:55
@Mark2000
Copy link
Contributor

Updated to not use sphinx-apidoc for more flexibility. Currently running make html in the docs folder should build everything.

@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch 4 times, most recently from 4d10695 to 54ea7b9 Compare January 5, 2024 07:41
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch from a5dd217 to 745c957 Compare January 5, 2024 08:44
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch 2 times, most recently from 3860273 to c1ff003 Compare January 5, 2024 22:58
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch 2 times, most recently from fbdbbb0 to 70f12af Compare January 23, 2024 21:47
@Mark2000 Mark2000 requested review from LorenzzoQM and Yume27 January 29, 2024 23:46
CITATION.cff Outdated Show resolved Hide resolved
docs/Makefile Outdated Show resolved Hide resolved
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch from 70f12af to 62db77f Compare January 30, 2024 18:23
@Mark2000 Mark2000 force-pushed the feature/17-sphinx-documentation branch from 62db77f to 8a15108 Compare January 30, 2024 18:42
@Mark2000
Copy link
Contributor

@LorenzzoQM addressed your comments and ready for approval

@LorenzzoQM
Copy link
Contributor

Thanks for making those changes. I just approved the pull request. This documentation is an excellent addition to the repo!

@Mark2000 Mark2000 merged commit fa6e6f9 into develop Jan 30, 2024
4 checks passed
@Mark2000 Mark2000 deleted the feature/17-sphinx-documentation branch January 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants