Skip to content

Commit

Permalink
Add PR links to PPP
Browse files Browse the repository at this point in the history
  • Loading branch information
LoMaply committed Nov 12, 2023
1 parent 1ee36ef commit df81734
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 19 deletions.
2 changes: 1 addition & 1 deletion docs/team/howenc.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ My contributions to the project are listed below.
- Managed [releases](https://github.com/AY2324S1-CS2103T-F12-4/tp/releases) `v1.2`-`v1.3(final)`

- **Enhancements to existing features**:
-

- Configured the model and storage to support Meetings. (Pull Request [#42](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/42))
- What it does: This was the groundwork needed for the rest of our project to happen.
- Highlights: The saving of the Attendees using Jackson proved quite difficult. The original implementation wanted the Person to be saved within the meeting. However, this would not be feasible as it would take up too much space and have a non-unique instance of a Person. This was resolved by using a string to represent the Person, as there cannot be 2 persons with the same name.
Expand Down
42 changes: 24 additions & 18 deletions docs/team/lomaply.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,43 +9,49 @@ OutBook is a desktop personal secretary application used for saving contacts and

My contributions to the project are listed below.

- **New Feature**:

- New Commands + Test cases
- `viewc`
- Command to view all details of a contact
- `viewm`
- Command to view all details of a meeting, including listing all attendees
- `editm`
- Command to edit fields of existing meetings based on Meeting list index
- Does not edit meeting Attendees as it is handled by `addmc` and `rmmc`

- **New Feature**: View contact command (Pull Request [#53](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/53))
- What it does: Allows the user to view all details of a contact.
- Highlights:
- This command required the first modification to the default GUI to make space for the viewed items display.
- Finding a way to send the viewed contact from the Command to the UI without unnecessarily increasing coupling was quite tricky. This was achieved by having the command store the viewed contact in the Model, and having the UI access it via the Logic Manager.
- Justification: This feature allows the user to see details of a contact, such as remarks, that may not be shown in the contact list due to space constraints.

- **New Feature**: View meeting command (Pull Request [#68](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/68))
- What it does: Allows the user to view all details of a meeting, similar to View contact command.
- Justification: This feature allows the user to see details of a meeting, such as the list of attendees, that may not be shown in the meeting list due to space constraints.

- **New Feature**: Edit meeting command (Pull Request [#80](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/80))
- What it does: Allows the user to edit all meeting details apart from the list of attendees, which is separately handles by `addmc` and `rmmc`.
- Highlights: While the implementation is quite similar to the existing edit contact command, some changes were required due to meetings having different data fields, with one of them (Attendees list) that should not be modifiable by this command.
- Justification: This feature allows users to edit incorrect/outdated meeting information, instead of having to delete and create a new meeting.


- **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=lomaply&breakdown=true)


- **Project management**:

- Maintain Issue Tracker
- Forking workflow
- Review and merge pull requests

- **Enhancements to existing features**:

- Split original UI (contact list) into 3 separate panes to make space for Meeting schedule and view commands
- Contact list automatically sorted by LastContactedTime
- Split original UI (contact list) into 3 separate panes (Pull Request [#53](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/53))
- Justification: Makes space for the Meeting Schedule and Display panel for the view commands.
- Contact list automatically sorted by LastContactedTime (Pull Request [#99](https://github.com/AY2324S1-CS2103T-F12-4/tp/pull/99))
- Justification: Ensures that Outbook users will easily stay in touch with their contacts by pushing contacts with the oldest LastContactedTime (with respect to the current date) to the top of the contact list.

- **Documentation**:

- User Guide
- First draft of User Guide with initial plans for v1.2
- Add section in User Guide for `viewm`, `viewc`, `editm`
- General polishing
- General polishing and error checking
- Developer Guide
- Add Implementation notes on `viewm`, `viewc`, `editc` and `editm`
- Add several Sequence & Class diagrams

- **Community**:

- to be added soon

- **Tools**:

- to be added soon

0 comments on commit df81734

Please sign in to comment.