From 3ff45528fcc31f0b6410cb42fb5578af5f51dd58 Mon Sep 17 00:00:00 2001 From: LHeng1 Date: Tue, 14 Nov 2023 02:46:51 +0800 Subject: [PATCH 1/2] Final draft of Heng Yi's PPP --- docs/team/lheng1.md | 45 +++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/docs/team/lheng1.md b/docs/team/lheng1.md index a3b08e94107..1b6414b8faf 100644 --- a/docs/team/lheng1.md +++ b/docs/team/lheng1.md @@ -10,37 +10,38 @@ TAfinder is a desktop resource management application used by NUS SOC professors * **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=lheng1&breakdown=true) + * **Enhancements implemented**: * Enhancement 1: Compare between two applicants - * What it does (How deep the enhancement is): The enhancement facilitates a side-by-side comparison of two applicants through a user interface (UI). - * Description (What is the enhancement doing): The UI displays comprehensive details of both applicants, including Student Number, Name, GPA, Interview Score, Previous Module Grade, and Comments. The window intelligently compares values (e.g., GPA, Interview Score, Previous Module Grade) and highlights the higher score for quick reference. This feature streamlines the decision-making process for selecting a Teaching Assistant (TA). - * Justification (Why it is complete): The implemented feature offers a holistic view of applicants' credentials and simplifies the decision-making process by highlighting superior scores. This ensures that the professor can easily discern which applicant excels in specific criteria. - * Highlights (How hard was it to implement): Creating the UI posed challenges, particularly in integrating it with the main window. Ultimately, a separate window was developed to pop up upon the execution of the compare command. - * Credits (If any): Special thanks to Ravern for inspiring the idea of utilizing a separate window. + * What it does: The enhancement facilitates a side-by-side comparison of two applicants through a user interface (UI). + * Description: The UI displays comprehensive details of both applicants, including Student Number, Name, GPA, Interview Score, Previous Module Grade, and Comments. The window intelligently compares values (e.g., GPA, Interview Score, Previous Module Grade) and highlights the higher score for quick reference. This feature streamlines the decision-making process for selecting a Teaching Assistant (TA). + * Justification: The implemented feature offers a holistic view of applicants' credentials and simplifies the decision-making process by highlighting superior scores. This ensures that the professor can easily discern which applicant excels in specific criteria. + * Highlights: Creating the UI posed challenges, particularly in integrating it with the main window. Ultimately, a separate window was developed to pop up upon the execution of the compare command. Besides, having to constantly update and integrate all the different parameters, including new ones created by my teammates ate up most of my time on doing the tP, as there were a lot of dependencies between each parameter. + * Credits: Special thanks to Ravern for inspiring the idea of utilizing a separate window. + * **Contributions to the UG**: - * Which sections did you contribute to the UG? - * Created the skeletal version of the UG for the team. + * Created the skeletal version of the UG for the team: [PR #52](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/52) + * In charge of updating the `edit` and `compare` function of UG: [PR #52](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/52), [PR #85](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/85) + * Helped check overall quality of UG. + * **Contributions to the DG**: - * Which sections did you contribute to the DG? Which UML diagrams did you add/updated? - * Created the compare command section under implementation. - * Created example use cases for the team. - * Created the user stories table. + * Created the compare command implementation details: [PR #95](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/95) + * Created sample use cases for the team: [PR #48](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/48) + * Update target user profile, value proposition, and user stories: [PR #47](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/47) + * In charge of Planned Enhancements appendix: [PR #206](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/206) + * **Contributions to team-based tasks**: - * Created demos for the milestones. - * Created labels and milestones in team GitHub page. + * Created deadlines for the milestones. + * Created labels and milestones in team GitHub page. + * Enabled assertions for the project: [PR #87](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/34) -* **Review/mentoring contributions**: - * Links to PRs reviewed, instances of helping team members in other ways. -* **Contributions beyond the project team**: - * Evidence of helping others e.g. responses you posted in our forum, bugs you reported in other team's products. - * Evidence of technical leadership e.g. sharing useful information in the forum. +* **Review/mentoring contributions**: + * Reviewed teammates' PRs: [PR #34](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/87), [PR #42](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/42), [PR #57](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/57), [PR #61](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/61), [PR #75](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/75), [PR #77](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/77), [PR #79](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/79), [PR #89](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/89), [PR #90](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/90), [PR #96](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/96), [PR #98](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/98), [PR #110](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/110), [PR #204](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/204), [PR #209](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/209) -* **Contributions to the Developer Guide (Extracts)**: - * Reproduce the parts in the Developer Guide that you wrote. Alternatively, you can show the various diagrams you contributed. -* **Contributions to the User Guide (Extracts)**: - * Reproduce the parts in the User Guide that you wrote. +* **Contributions beyond the project team**: + * Reported bugs and suggestions for other teams in the class: [PED repo](https://github.com/LHeng1/ped) From d671672ebe816d27fe1fcb24da45e8fcf690fc2e Mon Sep 17 00:00:00 2001 From: LHeng1 Date: Tue, 14 Nov 2023 04:33:11 +0800 Subject: [PATCH 2/2] Added final touch --- docs/team/lheng1.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/team/lheng1.md b/docs/team/lheng1.md index 1b6414b8faf..5b7d44043e6 100644 --- a/docs/team/lheng1.md +++ b/docs/team/lheng1.md @@ -23,7 +23,7 @@ TAfinder is a desktop resource management application used by NUS SOC professors * **Contributions to the UG**: * Created the skeletal version of the UG for the team: [PR #52](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/52) * In charge of updating the `edit` and `compare` function of UG: [PR #52](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/52), [PR #85](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/85) - * Helped check overall quality of UG. + * Helped check overall quality of UG: [PR #211](https://github.com/AY2324S1-CS2103T-W10-1/tp/pull/211) * **Contributions to the DG**: