Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ravern's PPP #190

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Update Ravern's PPP #190

merged 2 commits into from
Nov 11, 2023

Conversation

ravern
Copy link

@ravern ravern commented Nov 11, 2023 •
edited
Loading

This PR

  • Updates Ravern's PPP
  • Fixes the "0.1." numbering in all PPPs due to lack of h2

@ravern ravern requested a review from a team November 11, 2023 11:30
@ravern ravern added this to the v1.4 milestone Nov 11, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Merging #190 (50165e2) into master (6bc50ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage     70.17%   70.17%           
  Complexity      612      612           
=========================================
  Files           107      107           
  Lines          2364     2364           
  Branches        244      244           
=========================================
  Hits           1659     1659           
  Misses          618      618           
  Partials         87       87

nabonitasen
nabonitasen approved these changes Nov 11, 2023
View reviewed changes
Copy link

@nabonitasen nabonitasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravern ravern merged commit 1912819 into AY2324S1-CS2103T-W10-1:master Nov 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabonitasen nabonitasen nabonitasen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ravern @nabonitasen