-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG for query related commands #218
Conversation
docs/DeveloperGuide.md
Outdated
|
||
Queries a 'doctor' or 'patient' entry by indicating their name or a substring of their name. | ||
This command is implemented through the `QueryDoctor` and `QueryPatient` classes which extend the `Command` class. | ||
* Step 1. User enters an `find` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a not an*
docs/DeveloperGuide.md
Outdated
This command is implemented through the `QueryDoctor` and `QueryPatient` classes which extend the `Command` class. | ||
* Step 1. User enters an `find` command. | ||
* Step 2. The `AddressBookParser` will call `parseCommand` on the user's input string and return an instance of `findCommandParser`. | ||
* Step 3. The `parse` command in `FindCommandParser` calls `ParserUtil` to create instances of objects for each of the parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres no parseutil in the find command parse method
docs/DeveloperGuide.md
Outdated
* Step 6. The `execute` method in `FindCommand` executes and calls `updateFilteredPersonList` in model with the `NameContainsKeywordsPredicate` to get a filtered list of person entries of the entered keyword(s), both `patient` and `doctor` entries can be displayed. | ||
* Step 7. A Success message gets printed onto the results display to notify user and the list of matching results is produced. | ||
|
||
The sequence diagram below closely describes the interaction between the various components during the execution of the `DeleteAppointmentCommand`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Findappointment not delete
docs/DeveloperGuide.md
Outdated
|
||
* Step 1. User enters a `doctor` command. | ||
* Step 2. The `AddressBookParser` will call `parseCommand` on the user's input string and return an instance of `QueryDoctorCommandParser`. | ||
* Step 3. The `parse` command in `QueryDoctorCommandParser` calls `ParserUtil` to create instances of objects for each of the fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure if querydoctorcommand parser calls parserutil
docs/DeveloperGuide.md
Outdated
|
||
* Step 1. User enters a `patient` command. | ||
* Step 2. The `AddressBookParser` will call `parseCommand` on the user's input string and return an instance of `QueryPatientCommandParser`. | ||
* Step 3. The `parse` command in `QueryPatientCommandParser` calls `ParserUtil` to create instances of objects for each of the fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again not sure if it calls parserutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
find
patient
doctor
apptforpatient
apptfordoctor