Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug #241

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Debug #241

merged 2 commits into from
Apr 15, 2024

Conversation

alfaloo
Copy link
Collaborator

@alfaloo alfaloo commented Apr 15, 2024

No description provided.

@alfaloo alfaloo self-assigned this Apr 15, 2024
@alfaloo alfaloo added this to the v1.4 milestone Apr 15, 2024
Copy link
Collaborator

@officialchengyud officialchengyud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch on our grammar issues.

@@ -15,7 +15,7 @@ MediCLI is tailored built for hospital clerks/administrators or anyone who manag
### Prior knowledge:
MediCLI will be particularly beneficial for you are either (or both of):
- a fast-typer or,
- and familar with a CLI,
- and familiar with a CLI,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@officialchengyud officialchengyud merged commit a4c8d09 into AY2324S2-CS2103T-T15-1:master Apr 15, 2024
3 checks passed
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (23eecd3) to head (bac4ba4).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
- Coverage     79.18%   78.44%   -0.74%     
+ Complexity      678      671       -7     
============================================
  Files           105      104       -1     
  Lines          2095     2102       +7     
  Branches        222      228       +6     
============================================
- Hits           1659     1649      -10     
- Misses          370      374       +4     
- Partials         66       79      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants