Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate lesson and consult #218

Conversation

marcusjhang
Copy link

@marcusjhang marcusjhang commented Nov 3, 2024

PR for issue #193

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 89.51049% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../address/model/consultation/UniqueConsultList.java 91.30% 2 Missing and 2 partials ⚠️
...a/seedu/address/model/lesson/UniqueLessonList.java 91.30% 2 Missing and 2 partials ⚠️
...c/main/java/seedu/address/model/lesson/Lesson.java 40.00% 1 Missing and 2 partials ⚠️
...seedu/address/model/consultation/Consultation.java 66.66% 1 Missing and 1 partial ⚠️
...c/main/java/seedu/address/model/datetime/Date.java 0.00% 0 Missing and 1 partial ⚠️
...c/main/java/seedu/address/model/datetime/Time.java 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...logic/commands/consultation/AddConsultCommand.java 100.00% <100.00%> (ø) 9.00 <0.00> (+1.00)
...ddress/logic/commands/lesson/AddLessonCommand.java 76.47% <100.00%> (+3.13%) 7.00 <0.00> (ø)
src/main/java/seedu/address/model/AddressBook.java 92.39% <100.00%> (+1.04%) 32.00 <13.00> (-5.00) ⬆️
...el/lesson/exceptions/DuplicateLessonException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...c/main/java/seedu/address/model/datetime/Date.java 91.66% <0.00%> (ø) 12.00 <1.00> (ø)
...c/main/java/seedu/address/model/datetime/Time.java 91.66% <0.00%> (ø) 12.00 <1.00> (ø)
...seedu/address/model/consultation/Consultation.java 93.33% <66.66%> (-4.11%) 25.00 <4.00> (+4.00) ⬇️
...c/main/java/seedu/address/model/lesson/Lesson.java 94.44% <40.00%> (-4.07%) 30.00 <3.00> (+3.00) ⬇️
.../address/model/consultation/UniqueConsultList.java 91.30% <91.30%> (ø) 22.00 <22.00> (?)
...a/seedu/address/model/lesson/UniqueLessonList.java 91.30% <91.30%> (ø) 22.00 <22.00> (?)

... and 2 files with indirect coverage changes

@marcusjhang marcusjhang added this to the v1.5 milestone Nov 3, 2024
@notnotmax
Copy link

I think you might want to edit the PR description to link it to issue #193.

Copy link

@notnotmax notnotmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I think it will be safer to have testcases testing that trying to add duplicates does indeed throw an exception.

@Clarenceeey Clarenceeey merged commit d9ba531 into AY2425S1-CS2103T-F13-1:master Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants