Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reported pathing issues when using Import #311

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

yhanyi
Copy link

@yhanyi yhanyi commented Nov 9, 2024

Fixes #261 #276 #279

Addresses path related issues when using Import or ImportConsult as reported by testers.

@yhanyi yhanyi added the type.Bug A bug label Nov 9, 2024
@yhanyi yhanyi added this to the v1.6 milestone Nov 9, 2024
@yhanyi yhanyi self-assigned this Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ic/commands/consultation/ImportConsultCommand.java 83.33% 2 Missing and 1 partial ⚠️
...va/seedu/address/logic/commands/ImportCommand.java 90.90% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...va/seedu/address/logic/commands/ImportCommand.java 96.03% <90.90%> (-0.84%) 29.00 <4.00> (+1.00) ⬇️
...ic/commands/consultation/ImportConsultCommand.java 92.92% <83.33%> (+10.39%) 34.00 <5.00> (+9.00)

@yhanyi yhanyi marked this pull request as ready for review November 9, 2024 10:12
@notnotmax
Copy link

Just adding some reasoning for why I think this should be allowed.

The reasonable correct behavior is arguably for import and export to have the same base file paths.
image

@notnotmax notnotmax merged commit 3f20887 into AY2425S1-CS2103T-F13-1:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] import command read from inappropriate default directory
2 participants