Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for add to lesson #319

Merged

Conversation

Clarenceeey
Copy link

@Clarenceeey Clarenceeey commented Nov 10, 2024

Fixes #300 partially addresses #299

Previously, when the same student is added to the lesson in the same command, it throws an exception.

Now, the student will be added

@Clarenceeey Clarenceeey self-assigned this Nov 10, 2024
@Clarenceeey Clarenceeey added severity.Medium A flaw that causes occasional inconvenience to some users, but they can continue to use the product. type.Bug A bug labels Nov 10, 2024
@Clarenceeey Clarenceeey added this to the v1.6 milestone Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...ress/logic/commands/lesson/AddToLessonCommand.java 90.54% <100.00%> (+1.14%) 17.00 <0.00> (+5.00)

... and 3 files with indirect coverage changes

Copy link

@notnotmax notnotmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Also, I believe this should be allowed during feature freeze because it is clearly a 'bug' i.e. does not conform to reasonable expected behavior due to an error in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A flaw that causes occasional inconvenience to some users, but they can continue to use the product. type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] Test case 6 for addtolesson in DG fails
2 participants