Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for add to consult command #320

Merged

Conversation

Clarenceeey
Copy link

@Clarenceeey Clarenceeey commented Nov 10, 2024

Fixes #268 , partially addresses #299

Previously, when multiple of the same students are added in the same command, an exception is thrown.

Now, when that happens, the student is added successfully.

@Clarenceeey Clarenceeey added this to the v1.6 milestone Nov 10, 2024
@Clarenceeey Clarenceeey self-assigned this Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...gic/commands/consultation/AddToConsultCommand.java 95.23% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...gic/commands/consultation/AddToConsultCommand.java 88.88% <95.23%> (+0.55%) 16.00 <1.00> (+4.00)

... and 3 files with indirect coverage changes

Copy link

@notnotmax notnotmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see here for argument on why it should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Can't add student to a lesson if input its name and index simultaneously
2 participants