Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature: Edit Student Information #58

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

S-K-Y-Light
Copy link

Courses can be edited using the edit Feature.
Previously, User must enter Tags/Courses separately.
Now, User can edit multiple courses in one command, separating courses with ",".

Courses can be edited using the edit Feature.
Previously, User must enter Tags/Courses separately.
Now, User can edit multiple courses in one command, separating courses with ",".
@S-K-Y-Light S-K-Y-Light added the priority.High Must do label Oct 10, 2024
@S-K-Y-Light S-K-Y-Light added this to the v1.2 milestone Oct 10, 2024
@S-K-Y-Light S-K-Y-Light self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../seedu/address/logic/parser/EditCommandParser.java 50.00% 9 Missing and 2 partials ⚠️
...java/seedu/address/logic/commands/EditCommand.java 92.00% 0 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/EditCommand.java 94.11% <92.00%> (ø) 13.00 <2.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 67.50% <50.00%> (-25.10%) 12.00 <1.00> (+1.00) ⬇️

@S-K-Y-Light
Copy link
Author

TODO: Testing + Write Test Cases

# Conflicts:
#	src/main/java/seedu/address/logic/commands/EditCommand.java
Copy link

@notnotmax notnotmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, well done
Acknowledged that you want to write test cases in a separate PR.

@notnotmax notnotmax merged commit 9044e40 into AY2425S1-CS2103T-F13-1:master Oct 12, 2024
3 of 4 checks passed
@S-K-Y-Light S-K-Y-Light linked an issue Oct 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Feature: Update Student Information
2 participants