Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor person #59

Merged

Conversation

marcusjhang
Copy link

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 2 Missing ⚠️
...rc/main/java/seedu/address/ui/PersonListPanel.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 77.27% <ø> (ø) 3.00 <0.00> (ø)
src/main/java/seedu/address/logic/Messages.java 87.50% <ø> (ø) 3.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø) 12.00 <0.00> (+5.00)
...java/seedu/address/logic/commands/EditCommand.java 94.11% <100.00%> (ø) 13.00 <0.00> (ø)
...java/seedu/address/logic/commands/FindCommand.java 81.25% <100.00%> (ø) 5.00 <1.00> (ø)
.../seedu/address/logic/commands/FindNameCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 77.77% <ø> (ø) 4.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 83.01% <ø> (+2.16%) 17.00 <0.00> (+2.00)
... and 17 more

... and 1 file with indirect coverage changes

Copy link

@S-K-Y-Light S-K-Y-Light left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for Refactoring :)

@S-K-Y-Light S-K-Y-Light linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link

@Clarenceeey Clarenceeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clarenceeey Clarenceeey merged commit f0d405e into AY2425S1-CS2103T-F13-1:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Person into Student
3 participants