Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert abstract command #67

Closed

Conversation

yhanyi
Copy link

@yhanyi yhanyi commented Oct 13, 2024

Fixes #66

@yhanyi yhanyi added the priority.High Must do label Oct 13, 2024
@yhanyi yhanyi added this to the v1.3 milestone Oct 13, 2024
@yhanyi yhanyi self-assigned this Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/FindCommand.java 100.00% <100.00%> (+18.75%) 6.00 <1.00> (+1.00)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (+22.22%) 3.00 <2.00> (-1.00) ⬆️

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but is this supposed to be committed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, may have accidentally committed it when I meant to git stash save. Will fix in another commit.

@notnotmax
Copy link

I've made a duplicate PR #69 to contain the essential changes without the issues with build.gradle. Your name is on it, don't worry.
This PR will be closed.

@notnotmax notnotmax closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert FindCommand to concrete class
2 participants