Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG with PE-D issues #321

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

choiwab
Copy link

@choiwab choiwab commented Nov 10, 2024

Fixes #272 #273 #276 #279
-Added new screenshots to UG with appropriate inputs to DocTrack
-Added "Acceptable Inputs" column to Field table of Person and Appointment
-Add period to first two bullet points in introduction
-You --> you in FAQ

@choiwab choiwab added this to the v1.6 milestone Nov 10, 2024
@choiwab choiwab self-assigned this Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 84.72% <ø> (ø) 22.00 <0.00> (ø)

@choiwab choiwab requested a review from rxchell November 10, 2024 09:15
Copy link

@rxchell rxchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes!

Comment on lines +320 to +322
---
* Emails must have a local part containing alphanumeric characters and specific symbols (`+_.-`) (not at the start or end), followed by `@`, and a domain part with labels separated by periods, ending in a label with at least two alphanumeric characters, and no labels starting or ending with hyphens.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this with a separate note to make it neater!

@rxchell rxchell merged commit f1cd1e2 into AY2425S1-CS2103T-W10-2:master Nov 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] UG doctrack UI screenshot choice
2 participants