Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of a person and appointment #325

Conversation

zaidansani
Copy link

Resolves #318

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

Copy link

@rxchell rxchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good use of screenshots to explain the Ids of the person and appointment

@@ -316,6 +316,13 @@ A **person** is a patient with several fields. The fields and their correspondin
| **Tag(s)** | `t/` | Yes | Yes |

You can identify these patients uniquely by their **patient ID (PID)** for easy reference.
The PID can be seen at the top of their information card.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it more specific to say "top right" of their information card?

@@ -532,6 +539,18 @@ An **appointment** is defined by several fields. The fields and their correspond
| **Sickness** | `s/` | Yes | No |
| **Medicine** | `m/` | Yes | No |

You can identify these appointments uniquely by their **Appointment ID (AID)** for easy reference.
The AID can be seen at the top of their information card.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify top right as well?

@rxchell rxchell merged commit f1c4f07 into AY2425S1-CS2103T-W10-2:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester D] No Inclusion of glossary
2 participants