Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css fix plugin loading #117

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Css fix plugin loading #117

merged 5 commits into from
Nov 14, 2023

Conversation

sevisal
Copy link
Collaborator

@sevisal sevisal commented Nov 13, 2023

TL;DR

Fix issue when loading plugins

Plugin's structure change

Last merge regorganised the whole plugin loading to avoid loading a plugin in the template file. However, this made the plugin selection GUI code not be able to read the available functions and methods for these plugins. For this reason, I have added a flag to determine if we want to load the plugin or just initialise the module to read the available functions.

@sevisal sevisal requested a review from ruokolt November 13, 2023 16:12
@sevisal sevisal added the bug Something isn't working label Nov 13, 2023
@ruokolt
Copy link
Collaborator

ruokolt commented Nov 14, 2023

The logic seems valid to me.

@sevisal sevisal merged commit 2176ac6 into main Nov 14, 2023
5 checks passed
@sevisal sevisal deleted the css-fixPluginLoading branch November 14, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants