Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Commit

Permalink
Optional outcome prefix (#464)
Browse files Browse the repository at this point in the history
- [x] I have battle-tested on Overtaci (RMAPPS1279)
- [x] At least one of the commits is prefixed with either "fix:" or
"feat:"

## Notes for reviewers
Reviewers can skip X, but should pay attention to Y.
  • Loading branch information
MartinBernstorff authored Mar 28, 2023
2 parents 83e83dc + 7b74004 commit 5e6ca09
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def _get_possible_lookaheads(self) -> list[int]:
outcome_col_names = infer_outcome_col_name(
df=self.train_df,
allow_multiple=True,
prefix=self.cfg.data.outc_prefix,
)

potential_lookaheads: list[int] = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def create_base_plot_artifacts(self) -> list[ArtifactContainer]:
label="time_from_first_positive_to_event",
artifact=plot_time_from_first_positive_to_event(
eval_dataset=self.eval_ds,
bins=range(0, 730, 24),
bins=lookahead_bins,
save_path=self.save_dir / "time_from_first_positive_to_event.png",
),
),
Expand All @@ -149,8 +149,8 @@ def create_base_plot_artifacts(self) -> list[ArtifactContainer]:
label="recall_by_calendar_time",
artifact=plot_recall_by_calendar_time(
eval_dataset=self.eval_ds,
positive_rates=[0.95, 0.97, 0.99],
bins=self.cfg.eval.lookahead_bins,
pos_rate=[0.95, 0.97, 0.99],
bins=lookahead_bins,
y_limits=(0, 0.5),
save_path=self.save_dir / "recall_by_calendar_time.png",
),
Expand Down

0 comments on commit 5e6ca09

Please sign in to comment.