Replace uses of boost flat_map and flat_set with robin_map and robin_set #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fpsunflower
force-pushed
the
remove_boost_containers
branch
2 times, most recently
from
3359074
to
9d32687
Compare
|
Holy cow, would you believe I had just sat down to start working on this very problem, with the same solution of just using robin_map and robin_set? But had only gotten like 10 minutes into it. |
|
👍🏻 I'll take care of the CLA on Monday. |
|
Any progress? |
|
Its been signed -- we're working on getting it ingested into the EasyCLA system ... |
|
The celestial bodies have aligned and CLA has been taken care of :) I will rebase now. |
None of the code was actually dependent on the fact that these containers are sorted by key. Switching to the robin containers instead removes one less use of boost in the project. Signed-off-by: Chris Kulla <ckulla@gmail.com>
fpsunflower
force-pushed
the
remove_boost_containers
branch
from
9d32687
to
f35f7be
Compare
|
Now we know an eclipse was a necessary ingredient for the CLA Gods. |
lgritz
approved these changes
Apr 10, 2024
lgritz
merged commit 5472c84
into
AcademySoftwareFoundation:master
23 of 24 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 13, 2024
…set (AcademySoftwareFoundation#4191) A tiny bit more progress towards AcademySoftwareFoundation#4158. None of the code was actually dependent on the fact that these containers are sorted by key. Switching to the robin containers instead removes one less use of boost in the project. Signed-off-by: Chris Kulla <ckulla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A tiny bit more progress towards #4158.
None of the code was actually dependent on the fact that these containers are sorted by key. Switching to the robin containers instead removes one less use of boost in the project.
Tests
It passes the tests that I can run locally -- will be looking at the actual CI results to confirm everything passes, since I can't get all tests to pass locally (even without this change).
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.