Add support for synchronous mode in rez-pkg-cache #1834

Pixel-Minions · 2024-09-26T18:57:02Z

Add support for synchronous and asynchronous package caching modes via argparse in pkg-cache.py

linux-foundation-easycla · 2024-09-26T18:57:06Z

The committers listed above are authorized under a signed CLA.

✅ login: Pixel-Minions / name: Jose Enriquez (e7de86d, b6d2d73, 898a922, af46f92, 037879c, 007d24f, 98c4ea0, b30e478, 89416b8, d3f0dd3, 5411af6, 4724700, 2c00fb0, 06eaccf, 6c5c395, fe5fc96, d09c08d, 85aaa8d, fadd2ba, df4cf31, 4cd6fe9, 9ce3e02, fecb35a, 6380581, 0f1ac79, a2a7348, 61512b8, 7ed5ce6, bc6d5e4, 2038980, ab1b958, 296583c, 431f0ef, 8407a07, 6448462, c79f86e, ccd8241, 3bc7c5d, bb7872b, 12d0c66, ea1bc92, e2289c2, 1a0ee1f, 887d506, b2f8347, eb7fce5, 29bf0b5, 25ab47a, 46089ac, 507850e, 1482bfd, 907cd19, 548aa01, a6576c6, 4d23f59, 7eddca3, 52c2f79, a5a4b82, c2ec1b2, c011fa1, c1fc73e, d49bde0, 591a164, 8113ffd, 0d73bfa, 19ae9d6, 6d985f1, 9662448, d613670, 98b9051, 2aa7575, 24abaf8)

codecov · 2024-09-26T19:02:55Z

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.51%. Comparing base (8476696) to head (29bf0b5).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
src/rez/cli/pkg-cache.py	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   58.52%   58.51%   -0.01%     
==========================================
  Files         126      126              
  Lines       17207    17211       +4     
  Branches     3519     3520       +1     
==========================================
+ Hits        10070    10071       +1     
- Misses       6468     6471       +3     
  Partials      669      669

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…1640) Signed-off-by: Pavel Vergeev <vernier_06_curios@icloud.com>

…SoftwareFoundation#1644) Signed-off-by: Pavel Vergeev <vernier_06_curios@icloud.com>

Signed-off-by: Jose Enriquez <alenrqz21@gmail.com>

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

* Add support for virtualenv in installer Signed-off-by: Jose Enriquez <alenrqz21@gmail.com> * Run workflows when install script is modified Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> --------- Signed-off-by: Jose Enriquez <alenrqz21@gmail.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Signed-off-by: predat <sylvain@predat.fr>

…oftwareFoundation#1659) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

…emySoftwareFoundation#1660) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

…1673) * Delete rez/utils/json.py --------- Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

…oftwareFoundation#1678) * remove rez.utils.py23 module * remove some more __nonzero__ methods --------- Signed-off-by: wwn <1506514799@qq.com>

Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>

Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>

…areFoundation#1691) * Tick off several completed boxes in onboarding document Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com> * Update ASWF/ONBOARDING.md Signed-off-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> --------- Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com> Signed-off-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>

…Foundation#1666) This will fix issues when rez-cp could fail in some situations on WIndows. Signed-off-by: loonghao <hal.long@outlook.com>

AcademySoftwareFoundation#1672) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Previously, package orderers were only applied on packages. This was an oversight. With this change, they are now applied to variants too. --------- Signed-off-by: Ben Andersen <ben@isohedron.com.au> Co-authored-by: Paul Molodowitch <elrond79@gmail.com>

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

…wareFoundation#1677) Improve clarify of early binding functions documentation by documenting what is accessible within an early function. Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Signed-off-by: Jer <samson-jerome@users.noreply.github.com>

…ftwareFoundation#1696) Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

…on#1692) Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

…twareFoundation#1781) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

…1785) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...692973e) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dation#1784) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.2...6546280) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ndation#1783) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@23acc5c...b611370) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dation#1790) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…undation#1789) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@65a9edc...fa0a91b) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ndation#1795) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.12. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...4fa2a79) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ion#1794) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.0 to 5.1.1. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@82c7e63...39cd149) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ySoftwareFoundation#1798) Signed-off-by: Ruzette Krukkert <ruzettekrukkert@fusefx.com> Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Co-authored-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

…dation#1816) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.12 to 3.26.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4fa2a79...2c779ab) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dation#1814) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...834a144) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…tion#1805) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@dc50aa9...62b2cac) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ation#1827) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.5 to 3.26.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@2c779ab...8214744) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ion#1820) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...f677139) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…dation#1819) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@834a144...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ocs (AcademySoftwareFoundation#1804) Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst) - [Commits](sphinx-doc/sphinx@v7.0.0...v8.0.0) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…areFoundation#1778) Fixes issue where powershell plugins were not correctly capturing exit codes when aliased commands failed (AcademySoftwareFoundation#1778) --------- Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com> Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>

…rip. Also bumped the serialization formation from 4.7 to 4.8 (AcademySoftwareFoundation#1810) Signed-off-by: Nathan Rusch <nathan.rusch@scanlinevfx.com>

- Introduced `--pkg-cache-mode` argument to specify caching mode (`sync` or `async`). - Updated `add_variant` function to handle the new caching modes.

Pixel-Minions · 2024-09-26T21:38:07Z

@JeanChristopheMorinPerso For review

JeanChristopheMorinPerso · 2024-10-13T19:12:02Z

@Pixel-Minions I'm not too sure how you created your branch, but there is a lot of commits that are not from you and DCO fails because of that.

JeanChristopheMorinPerso · 2024-10-14T19:29:18Z

Closing in favor of #1853

Pixel-Minions requested a review from a team as a code owner September 26, 2024 18:57

Pixel-Minions force-pushed the enhancements branch from 5c133f7 to f8271fc Compare September 26, 2024 21:13

Pixel-Minions and others added 26 commits September 26, 2024 17:26

Remove Python2-related __future__ imports (AcademySoftwareFoundation#…

6380581

…1640) Signed-off-by: Pavel Vergeev <vernier_06_curios@icloud.com>

Remove the note about Python 2.7 compatibility from the docs (Academy…

ab1b958

…SoftwareFoundation#1644) Signed-off-by: Pavel Vergeev <vernier_06_curios@icloud.com>

Add support for virtualenv in installer

a2a7348

Signed-off-by: Jose Enriquez <alenrqz21@gmail.com>

Run workflows when install script is modified

06eaccf

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Remove rez.vendor.enum (AcademySoftwareFoundation#1649)

d09c08d

Signed-off-by: predat <sylvain@predat.fr>

Add clear information on how to contact project maintainers (AcademyS…

296583c

…oftwareFoundation#1659) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Improve install docs by mentioning how to actually download rez (Acad…

037879c

…emySoftwareFoundation#1660) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Remove rez.backport (AcademySoftwareFoundation#1634)

9ce3e02

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Upload test coverage to Codecov (AcademySoftwareFoundation#1671)

887d506

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Remove Python 2 support for utils/json.py (AcademySoftwareFoundation#…

61512b8

…1673) * Delete rez/utils/json.py --------- Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Add development environment docs (AcademySoftwareFoundation#1633)

85aaa8d

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Remove rez.utils.py23 and cleanup more python 2.7 leftovers (AcademyS…

4724700

…oftwareFoundation#1678) * remove rez.utils.py23 module * remove some more __nonzero__ methods --------- Signed-off-by: wwn <1506514799@qq.com>

Improve explicitness of help doc of --command on rez-env

7ed5ce6

Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>

Address notes

0f1ac79

Signed-off-by: brycegbrazen <bryce.gattis@brazenanimation.com>

update sonarcloud python property (AcademySoftwareFoundation#1686)

5411af6

Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>

Add retry mechanism when renaming folders on Windows (AcademySoftware…

df4cf31

…Foundation#1666) This will fix issues when rez-cp could fail in some situations on WIndows. Signed-off-by: loonghao <hal.long@outlook.com>

Add -e/--editable flag to install script to create an editable install (

3bc7c5d

AcademySoftwareFoundation#1672) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Add releasing packages documentation (AcademySoftwareFoundation#1689)

ccd8241

Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Improve clarify of early binding functions documentation (AcademySoft…

af46f92

…wareFoundation#1677) Improve clarify of early binding functions documentation by documenting what is accessible within an early function. Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Bump version to 3.1.0 (AcademySoftwareFoundation#1702)

d3f0dd3

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Fix typo in "Releasing packages" docs (AcademySoftwareFoundation#1704)

fe5fc96

Signed-off-by: Jer <samson-jerome@users.noreply.github.com>

Remove unnecessary variable assignment in rez.deprecations (AcademySo…

6c5c395

…ftwareFoundation#1696) Signed-off-by: Bryce Gattis <brycegattis@yahoo.com>

Pixel-Minions and others added 20 commits September 26, 2024 17:27

Pin GH actions to commit hash as recommended by scorecard (AcademySof…

6d985f1

…twareFoundation#1781) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Restrict permissions in GHA workflows (AcademySoftwareFoundation#1782)

c2ec1b2

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>

Fix package_cache_async missing from ResolvedContext dict round-t…

591a164

…rip. Also bumped the serialization formation from 4.7 to 4.8 (AcademySoftwareFoundation#1810) Signed-off-by: Nathan Rusch <nathan.rusch@scanlinevfx.com>

Add support for synchronous and asynchronous package caching modes

25ab47a

- Introduced `--pkg-cache-mode` argument to specify caching mode (`sync` or `async`). - Updated `add_variant` function to handle the new caching modes.

Pixel-Minions force-pushed the enhancements branch from ea2afe1 to 25ab47a Compare September 26, 2024 21:34

Merge https://github.com/Pixel-Minions/rez into enhancements

29bf0b5

JeanChristopheMorinPerso added the Blocked by DCO Waiting on commit signoff label Oct 13, 2024

JeanChristopheMorinPerso added this to the Next milestone Oct 13, 2024

JeanChristopheMorinPerso changed the title ~~Add support for synchronous and asynchronous package caching modes~~ Add support for synchronous mode in rez-pkg-cache Oct 13, 2024

JeanChristopheMorinPerso closed this Oct 14, 2024

JeanChristopheMorinPerso removed this from the Next milestone Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for synchronous mode in rez-pkg-cache #1834

Add support for synchronous mode in rez-pkg-cache #1834

Pixel-Minions commented Sep 26, 2024

linux-foundation-easycla bot commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading

Pixel-Minions commented Sep 26, 2024

JeanChristopheMorinPerso commented Oct 13, 2024

JeanChristopheMorinPerso commented Oct 14, 2024

Add support for synchronous mode in rez-pkg-cache #1834

Add support for synchronous mode in rez-pkg-cache #1834

Conversation

Pixel-Minions commented Sep 26, 2024

linux-foundation-easycla bot commented Sep 26, 2024 • edited Loading

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

Pixel-Minions commented Sep 26, 2024

JeanChristopheMorinPerso commented Oct 13, 2024

JeanChristopheMorinPerso commented Oct 14, 2024

linux-foundation-easycla bot commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading