Implement support for company registration number #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same approach as for SwedishPersonalIdentityNumber. Any shared logic has been extracted to re-usable modules. And a new discriminated union IdentityNumber that holds either a SwedishPersonalIdentityNumber or a CoordinationNumber has been introduced. The relevant tests for CoordinationNumber has been copied from SwedishPersonalIdentityNumber tests. To follow the same approach the generators for the tests are using the test PersonalIdentity numbers from Skatteverket and are turning them into CoordinationNumbers by adding 60 to the Day, and recalculating the checksum.
…ing function to Parse.fs
IdentityNumber. Update doc-comments.
Add C# extension methods for the IdentityNumber-type. Update the C# and F# samples to use IdentityNumber and demonstrate uses of SwedishPersonalIdentityNumber and SwedishCoordinationNumber. Add some missing doc-comments.
Rename IdentityNumber -> IndividualIdentityNumber which is a better name for the future when we will support company registration numbers as well. In the same spirit, remove the IdentityValues type that was tightly coupled to the personal and coordination numbers. It is more generic to use a tuple as input, which incidentally will make the F#- and C# apis have the same signature.
|
Oh, this should have been a draft PR, but apparently you cannot change to a draft PR, only make it a draft when you create it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for company registration numbers.
TODO: